[PATCH] D55222: [AST] Assert that no statement/expression class is polymorphic

2018-12-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348278: [AST] Assert that no statement/expression class is polymorphic (authored by brunoricci, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55222/new/ ht

[PATCH] D55222: [AST] Assert that no statement/expression class is polymorphic

2018-12-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55222/new/ https://reviews.llvm.org/D55222 ___

[PATCH] D55222: [AST] Assert that no statement/expression class is polymorphic

2018-12-03 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno updated this revision to Diff 176435. riccibruno added a comment. Forgot a space in the error message Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55222/new/ https://reviews.llvm.org/D55222 Files: lib/AST/Stmt.cpp Index: lib/AST/Stmt.cpp

[PATCH] D55222: [AST] Assert that no statement/expression class is polymorphic

2018-12-03 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Add a `static_assert` checking that no statement/expression class is polymorphic. People should use LLVM style RTTI instead. Repository: rC