This revision was automatically updated to reflect the committed changes.
Closed by commit rL348120: [OpenCL][Sema] Improve BuildResolvedCallExpr
handling of builtins (authored by mantognini, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
Anastasia added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:5556
// Extract the return type from the (builtin) function pointer type.
-auto FnPtrTy = Context.getPointerType(FDecl->getType());
+// FIXME Several builtins still have setType in
Sema::CheckBuiltin
riccibruno accepted this revision.
riccibruno added a comment.
This revision is now accepted and ready to land.
Much better. LGTM with a small format nit.
Comment at: lib/Sema/SemaExpr.cpp:5556
// Extract the return type from the (builtin) function pointer type.
-auto
mantognini created this revision.
mantognini added a reviewer: riccibruno.
Herald added subscribers: cfe-commits, kristina, yaxunl.
This is a follow-up on https://reviews.llvm.org/D52879, addressing a few issues.
This:
- adds a FIXME for later improvement for specific builtins: I previously have
