[PATCH] D55083: Re-arrange content in FunctionDecl dump

This revision was automatically updated to reflect the committed changes. Closed by commit rC351269: Re-order overrides in FunctionDecl dump (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55083?vs=181744&id=181892#toc Repository: rC Clang CHANGES S

[PATCH] D55083: Re-arrange content in FunctionDecl dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some nit cleanup. Comment at: lib/AST/ASTDumper.cpp:648 + + if (const CXXConstructorDecl *C = dyn_cast(D)) +for (CXXConstructorDecl::init_c

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire marked an inline comment as done. steveire added inline comments. Comment at: test/AST/ast-dump-funcs.cpp:59 // CHECK: CXXMethodDecl 0x{{[^ ]*}} col:8 f 'void (float, int)' + // CHECK-NEXT: Overrides: [ 0x{{[^ ]*}} S::f 'void (float, int)' ] // CHECK-NEXT: ParmV

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire updated this revision to Diff 181744. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55083/new/ https://reviews.llvm.org/D55083 Files: lib/AST/ASTDumper.cpp test/AST/ast-dump-funcs.cpp Index: test/AST/ast-dump-funcs

[PATCH] D55083: Re-arrange content in FunctionDecl dump

aaron.ballman added inline comments. Comment at: test/AST/ast-dump-decl.cpp:217 // CHECK-NEXT: ParmVarDecl +// CHECK-NEXT: TemplateArgument // CHECK-NEXT: CompoundStmt I find this ordering to be confusing, especially because the template argument i

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire updated this revision to Diff 177069. steveire added a comment. Adjust tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55083/new/ https://reviews.llvm.org/D55083 Files: lib/AST/ASTDumper.cpp test/AST/ast-dump-decl.cpp test/AST/ast-dump-funcs.c

[PATCH] D55083: Re-arrange content in FunctionDecl dump

aaron.ballman added a comment. In D55083#1314546 , @steveire wrote: > Yes, please commit your new tests for FunctionDecl dumping before this patch > can go in. r347994 has those tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire added a comment. Yes, please commit your new tests for FunctionDecl dumping before this patch can go in. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55083/new/ https://reviews.llvm.org/D55083 ___ cfe-comm

[PATCH] D55083: Re-arrange content in FunctionDecl dump

aaron.ballman added a comment. The summary explains what it's doing, but not why it's doing it -- why is this change in behavior needed? Does this not break any tests? Btw, as we work on this refactoring, I think a good approach will be to build up the base of tests around AST dumping so that w

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Output all content which is local to the FunctionDecl before traversing to child AST nodes. Repository: rC Clang https://reviews.llvm.org/D55083 Files: lib/AST/ASTDumper.cpp