[PATCH] D55068: NFC: Simplify dumpStmt child handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL348189: NFC: Simplify dumpStmt child handling (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D55068: NFC: Simplify dumpStmt child handling

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D55068#1315924 , @steveire wrote: > Aaron, you added tests for the existing behavior which pass after this patch. > Is there anything

[PATCH] D55068: NFC: Simplify dumpStmt child handling

steveire added a comment. Aaron, you added tests for the existing behavior which pass after this patch. Is there anything holding it up? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55068/new/ https://reviews.llvm.org/D55068 _

[PATCH] D55068: NFC: Simplify dumpStmt child handling

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:1987 +ConstStmtVisitor::Visit(S); + aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote: > > > Was there something special about calling

[PATCH] D55068: NFC: Simplify dumpStmt child handling

aaron.ballman added inline comments. Comment at: lib/AST/ASTDumper.cpp:1987 +ConstStmtVisitor::Visit(S); + steveire wrote: > aaron.ballman wrote: > > Was there something special about calling the Visit methods directly and > > bailing out? Your code certai

[PATCH] D55068: NFC: Simplify dumpStmt child handling

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:1987 +ConstStmtVisitor::Visit(S); + aaron.ballman wrote: > Was there something special about calling the Visit methods directly and > bailing out?

[PATCH] D55068: NFC: Simplify dumpStmt child handling

steveire updated this revision to Diff 175956. steveire added a comment. Use isa instead of dyn_cast Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55068/new/ https://reviews.llvm.org/D55068 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp ==

[PATCH] D55068: NFC: Simplify dumpStmt child handling

aaron.ballman added inline comments. Comment at: lib/AST/ASTDumper.cpp:1987 +ConstStmtVisitor::Visit(S); + Was there something special about calling the Visit methods directly and bailing out? Your code certainly looks reasonable, but I wonder if the outpu

[PATCH] D55068: NFC: Simplify dumpStmt child handling

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55068 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp =