[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

2018-12-04 Thread Max Moroz via Phabricator via cfe-commits
Dor1s updated this revision to Diff 176712. Dor1s added a comment. Restore the message with a couple clarifying words. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55066/new/ https://reviews.llvm.org/D55066 Files: docs/AddressSanitizer.rst Index: docs/Addre

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

2018-12-03 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added a comment. How about "Static linking of executables is not supported"? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55066/new/ https://reviews.llvm.org/D55066 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

2018-12-03 Thread Max Moroz via Phabricator via cfe-commits
Dor1s added a comment. In D55066#1315365 , @eugenis wrote: > Sorry for the delay. > This is wrong, static linking is NOT supported. > You could be confusing it with static linking of asan runtime library to an > executable - that is and has always been

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

2018-11-30 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis requested changes to this revision. eugenis added a comment. This revision now requires changes to proceed. Sorry for the delay. This is wrong, static linking is NOT supported. You could be confusing it with static linking of asan runtime library to an executable - that is and has always

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

2018-11-30 Thread Max Moroz via Phabricator via cfe-commits
Dor1s added a comment. PTAL, it's a single line change, I just need someone to confirm that I'm not mistaken :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55066/new/ https://reviews.llvm.org/D55066 ___ cfe-commi

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

2018-11-29 Thread Max Moroz via Phabricator via cfe-commits
Dor1s created this revision. Dor1s added reviewers: eugenis, kcc. Herald added a subscriber: cfe-commits. Looks like the documentation is out of date, given that static linking is not only supported these days, but is actually a default mode. Repository: rC Clang https://reviews.llvm.org/D550