This revision was automatically updated to reflect the committed changes.
Closed by commit rC348006: [clang] Fill RealPathName for virtual files.
(authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55054?vs=176146&id=176147#toc
Repository:
rC Clang
CHAN
kadircet updated this revision to Diff 176146.
kadircet marked 5 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55054/new/
https://reviews.llvm.org/D55054
Files:
include/clang/Basic/FileManag
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM and a few nits
Comment at: include/clang/Basic/FileManager.h:108
+
+ // Only for use in tests to see if deferred opens are happening, arther than
+ // re
kadircet added inline comments.
Comment at: unittests/Basic/FileManagerTest.cpp:237
ASSERT_TRUE(file->isValid());
// "real path name" reveals whether the file was actually opened.
EXPECT_EQ("", file->tryGetRealPathName());
ilya-biryukov wrote:
> This tes
kadircet updated this revision to Diff 176078.
kadircet marked 5 inline comments as done.
kadircet added a comment.
Address comments
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55054/new/
https://reviews.llvm.org/D55054
Files:
include/clang/Basic/FileManager
ilya-biryukov added inline comments.
Comment at: include/clang/Basic/FileManager.h:177
+ /// Fills the RealPathName entry in UFE by converting the given filename to
an
+ /// absolute path, returns true if FileName was modified.
+ bool fillRealPathName(FileEntry *UFE, llvm::St
kadircet updated this revision to Diff 175898.
kadircet added a comment.
- Update tests
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55054/new/
https://reviews.llvm.org/D55054
Files:
include/clang/Basic/FileManager.h
lib/Basic/FileManager.cpp
unittests/Ba
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added a subscriber: cfe-commits.
Absolute path information for virtual files were missing even if we
have already stat'd the files. This patch puts that information for virtual
files that can succesffully be stat'd.
