[PATCH] D55052: Fix junk output in clangd vscode plugin

hokein added a comment. > Yeah, there are still modes where clangd behaves badly there. Note that the > output from that pane is rarely useful anyway as clangd keeps producing > errors about accessing non-open files, which would confuse people even more. > Overall we never designed this output

[PATCH] D55052: Fix junk output in clangd vscode plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL347968: [clangd] Fix junk output in clangd vscode plugin (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55052?vs=175897&

[PATCH] D55052: Fix junk output in clangd vscode plugin

jfindley marked an inline comment as done. jfindley added a comment. In D55052#1313048 , @ioeric wrote: > James, do you have commit access to llvm? If not, I'm happy to land the patch > for you. I do not have commit access - if you could land it that wo

[PATCH] D55052: Fix junk output in clangd vscode plugin

ioeric added a comment. James, do you have commit access to llvm? If not, I'm happy to land the patch for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55052/new/ https://reviews.llvm.org/D55052 ___ cfe-commits mailing list cfe-commit

[PATCH] D55052: Fix junk output in clangd vscode plugin

jfindley updated this revision to Diff 175897. jfindley added a comment. Changed the comment to be a little more helpful. I used 'output' rather than errors because depending on verbosity level it can be more than just errors printed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5505

[PATCH] D55052: Fix junk output in clangd vscode plugin

ilya-biryukov added a comment. In D55052#1312766 , @hokein wrote: > For cancellation errors, it might be reasonable, but what if other > unrecoverable errors in clangd (e.g. clangd crashes), in these cases, users > don't know what happens, and would stil

[PATCH] D55052: Fix junk output in clangd vscode plugin

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. In D55052#1312766 , @hokein wrote: > In D55052#1312760 , @ilya-biryukov > wrote: > > > +1 to the change, this

[PATCH] D55052: Fix junk output in clangd vscode plugin

hokein added a comment. In D55052#1312760 , @ilya-biryukov wrote: > +1 to the change, this is annoying for me too. > > In D55052#1312753 , @hokein wrote: > > > @jfindley I'd like to understand how do these log mess

[PATCH] D55052: Fix junk output in clangd vscode plugin

ilya-biryukov added inline comments. Comment at: clangd/clients/clangd-vscode/src/extension.ts:58 +}, +// Avoid lots of junk in output +revealOutputChannelOn: vscodelc.RevealOutputChannelOn.Never ilya-biryukov wrote: > Could we rephrase th

[PATCH] D55052: Fix junk output in clangd vscode plugin

ilya-biryukov added inline comments. Comment at: clangd/clients/clangd-vscode/src/extension.ts:58 +}, +// Avoid lots of junk in output +revealOutputChannelOn: vscodelc.RevealOutputChannelOn.Never Could we rephrase this? Something like `//

[PATCH] D55052: Fix junk output in clangd vscode plugin

ilya-biryukov added a comment. +1 to the change, this is annoying for me too. In D55052#1312753 , @hokein wrote: > @jfindley I'd like to understand how do these log messages noise you? Does > the window prompt up to you automatically (this only happens w

[PATCH] D55052: Fix junk output in clangd vscode plugin

hokein added a comment. @jfindley I'd like to understand how do these log messages noise you? Does the window prompt up to you automatically (this only happens when there is an error in clangd)? These messages only get print to the `clangd-vscode` output panel which is used for debugging purpo

[PATCH] D55052: Fix junk output in clangd vscode plugin

jfindley marked an inline comment as done. jfindley added inline comments. Comment at: clangd/clients/clangd-vscode/src/extension.ts:59 +// Avoid lots of junk in output +revealOutputChannelOn: vscodelc.RevealOutputChannelOn.Never }; ioeric wr

[PATCH] D55052: Fix junk output in clangd vscode plugin

ioeric added a comment. Thanks for the patch James! Adding folks who are currently using vscode+clangd to get more opinions. Comment at: clangd/clients/clangd-vscode/src/extension.ts:59 +// Avoid lots of junk in output +revealOutputChannelOn: vscodelc.RevealOut

[PATCH] D55052: Fix junk output in clangd vscode plugin

jfindley created this revision. jfindley added a reviewer: ioeric. jfindley added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. When using the vscode clangd plugin, lots and lots of junk output is printed to the output w