[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

peter.smith added a comment. In D55029#1313120 , @ruiu wrote: > LGTM. Please commit. > > Peter, I wonder if you are fine with the default 64KiB page size with lld, > especially given that lld always round up the text segment size to the > maximum page si

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rC347897: set default max-page-size to 4KB in lld for Android Aarch64 (authored by zhizhouy, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55029/new/ https:/

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

ruiu accepted this revision. ruiu added a comment. LGTM. Please commit. Peter, I wonder if you are fine with the default 64KiB page size with lld, especially given that lld always round up the text segment size to the maximum page size on disk and fill the padding with trap instructions. On ave

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

zhizhouy added a comment. Thanks for the review and comments! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55029/new/ https://reviews.llvm.org/D55029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

peter.smith added a comment. Yes this is fine. The effects are entirely within the Android target. The change in LLD to a 64k page size was made in D25079 . The main reason given was that a sufficient number of linux distributions including Redhat had chosen a 6

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

ruiu added a comment. Yeah, I believe this patch is fine to submit, but since Peter is in a different timezone, I wanted give him a chance to review this one. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55029/new/ https://reviews.llvm.org/D55029 ___

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

srhines added a comment. In D55029#1312167 , @ruiu wrote: > I wouldn't rush to submit this now, given that this issue is not new at all. > Maybe we can just wait for Peter's response? Sure, that's fine too. I misunderstood the "tangent" part of your ini

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

ruiu added a comment. I wouldn't rush to submit this now, given that this issue is not new at all. Maybe we can just wait for Peter's response? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55029/new/ https://reviews.llvm.org/D55029 __

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks Zhizhou! I'm curious about Peter's answer to the 64KiB default as well, but I think we should move forward with getting this patch submitted. Repository: rC Clang CHANGES SINCE LA

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

ruiu added a comment. +peter.smith Somewhat tangent to this patch, but is 64KiB a reasonable default for `-z max-page-size`? I believe that max-page-size is set to 64KiB so that OS/CPU whose minimum page size is 64KiB can load an executable linked with lld, but is there any real target OS/CPU

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

zhizhouy created this revision. zhizhouy added reviewers: srhines, danalbert, ruiu, chh. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. This patch passes an option '-z max-page-size=4096' to lld through clang driver. This is for Android on Aarch64 target. The lld default page