This revision was automatically updated to reflect the committed changes.
Closed by commit rL347567: [clangd] Enable auto-index behind a flag. (authored
by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: test/clangd/background-index.test:16
+# Test that the index is writing files in the expected location.
+# RUN: ls %t/.clangd-index/foo.cpp.*.idx
+
kadircet wrote:
> kadircet
sammccall updated this revision to Diff 175249.
sammccall marked an inline comment as done.
sammccall added a comment.
Make blockUntilIdleForTest() accept a timeout, update comment.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54894/new/
https://re
kadircet added inline comments.
Comment at: test/clangd/background-index.test:13
+# The background index should allow us to go-to-definition on foo().
+# RUN: clangd -background-index -lit-test < %t/definition.jsonrpc | FileCheck
%t/definition.jsonrpc
+
kadircet
kadircet added inline comments.
Comment at: test/clangd/background-index.test:16
+# Test that the index is writing files in the expected location.
+# RUN: ls %t/.clangd-index/foo.cpp.*.idx
+
kadircet wrote:
> and this
also I suppose we might wanna delete this fil
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
Sorry for the bugs, thanks for the fixes :D
Comment at: clangd/ClangdServer.cpp:515
+if (BackgroundIdx)
+ BackgroundIdx->blockUntilIdleForTest();
+return tru
ioeric added a comment.
lgtm (will let @kadircet stamp )
Comment at: test/clangd/background-index.test:19
+# Test the index is read from disk: delete code and restart clangd.
+# This test currently fails as we don't read the index yet.
+# RUN: rm %t/foo.cpp
May
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Ownership and configuration:
The auto-index (background index) is maintained by ClangdServer, like Dynamic.
(This means ClangdServer wil
