[PATCH] D54878: [clangd] NFC: Eliminate the unused variable warning.

MTC updated this revision to Diff 175232. MTC added a comment. Use more concise form. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54878/new/ https://reviews.llvm.org/D54878 Files: clangd/AST.cpp Index: clangd/AST.cpp =

[PATCH] D54878: [clangd] NFC: Eliminate the unused variable warning.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. Ah, sorry, landed a cleanup fixing the warnings (rL347539 ) before seeing this change. But given that `isa<>` are still better than `dyn_cast<>`, this change might still be worth landing. R

[PATCH] D54878: [clangd] NFC: Eliminate the unused variable warning.

MTC marked an inline comment as done. MTC added inline comments. Comment at: clangd/AST.cpp:98 // The name was empty, so present an anonymous entity. - if (auto *NS = llvm::dyn_cast(&ND)) + if (isa(&ND)) return "(anonymous namespace)"; MaskRay wrote: >

[PATCH] D54878: [clangd] NFC: Eliminate the unused variable warning.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clangd/AST.cpp:98 // The name was empty, so present an anonymous entity. - if (auto *NS = llvm::dyn_cast(&ND)) + if (isa(&ND)) return "(anonymous

[PATCH] D54878: [clangd] NFC: Eliminate the unused variable warning.

MTC created this revision. MTC added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54878 Files: clangd/AST.cpp Index: clangd/AST.cpp =