This revision was automatically updated to reflect the committed changes.
Closed by commit rC347462: [ASTMatchers] Add hasSideEffect() matcher. (authored
by courbet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54830?vs=175044&id=175045#toc
Repository:
rC Clang
https:/
courbet updated this revision to Diff 175044.
courbet added a comment.
address comment
Repository:
rC Clang
https://reviews.llvm.org/D54830
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTM
courbet marked an inline comment as done.
courbet added a comment.
Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D54830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a minor commenting request.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4121
+/// \brief Matches expressions with potential side effec
courbet updated this revision to Diff 175031.
courbet added a comment.
rebase
Repository:
rC Clang
https://reviews.llvm.org/D54830
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersNa
courbet created this revision.
courbet added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Exposes Expr::HasSideEffects.
Repository:
rC Clang
https://reviews.llvm.org/D54830
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMat
