This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE347669: [clangd] Put direct headers into srcs section.
(authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54817?vs=175483&id=175486#toc
Repository:
rCTE Clang
kadircet updated this revision to Diff 175483.
kadircet marked 6 inline comments as done.
kadircet added a comment.
- Address comments.
- Move digest and digestFile into SourceCode.h
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54817/new/
https://r
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Only really significant thing is I think the name "build graph" is confusing,
and we should specifically mention includes.
Rest is just nits to take or leave...
Commen
kadircet updated this revision to Diff 175469.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Only keep the build graph structures and {de,}serialization logic.
- Rename a few structures, move to more relavant places.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LA
sammccall added a comment.
To summarize offline discussion: I think we need to split this patch up, as the
scope is growing. (In a really useful direction I think!)
The first patch should add the include graph data structure. (I think the right
place for it is probably Headers.h, as we want to
sammccall added a comment.
structure and serialization stuff looks great!
still some questions around the auto-index logic and organization of the
extraction code, let's chat offline. May make sense to split.
Comment at: clangd/index/Background.cpp:329
+llvm::StringMap
+Includ
kadircet updated this revision to Diff 175412.
kadircet added a comment.
- Rebase to get changes in background index.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54817/new/
https://reviews.llvm.org/D54817
Files:
clangd/index/Background.cpp
cl
kadircet updated this revision to Diff 175097.
kadircet added a comment.
- rebased and changed URI convertion patterns, since it changed in
https://reviews.llvm.org/rL347467
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54817
Files:
clangd/index/Background.cpp
clangd/inde
kadircet updated this revision to Diff 175087.
kadircet marked an inline comment as done.
kadircet added a comment.
- Change srcs to store multiple source file information rathet than one.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54817
Files:
clangd/index/Background.cpp
sammccall added a comment.
Going to leave awkward comments suggesting we expand the scope a bit.
Full disclosure: file dependency information is something that's come up as
useful in lots of contexts.
Comment at: clangd/index/Serialization.cpp:469
+ // There's no point in p
kadircet updated this revision to Diff 175032.
kadircet added a comment.
- Use include depth to get includes for all files, rather than just main file.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54817
Files:
clangd/index/Background.cpp
clangd/index/Background.h
clangd
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Currently, there's no way of knowing about header files
using compilation database, since it doesn't contain header files as entries.
Us
12 matches
Mail list logo
