This revision was automatically updated to reflect the committed changes.
Closed by commit rL347449: Move the llvm lit test dependencies to
clang-tools-extra. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54798
File
mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
LGTM (assuming you've tested it).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54798
___
cfe-commits mailing list
cfe-commits@
hokein updated this revision to Diff 175021.
hokein added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54798
Files:
test/CMakeLists.txt
Index: test/CMakeLists.txt
===
--- test/CMa
mgorny added inline comments.
Comment at: test/CMakeLists.txt:76
+# Add lit test dependencies.
+set(llvm_utils_deps
+ FileCheck count not
Nitpicking a bit but I think it would be better to uppercase it for consistency.
Comment at: test/CMakeLi
hokein created this revision.
hokein added a reviewer: mgorny.
Part of revert r343473
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54798
Files:
test/CMakeLists.txt
Index: test/CMakeLists.txt
===
--- test/CMak