This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rL347450: [clangd] Respect task cancellation in TUScheduler.
(authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to com
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE347450: [clangd] Respect task cancellation in TUScheduler.
(authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54746?vs=174738&id=175025#toc
Repository:
rL LL
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/TUScheduler.cpp:598
+if (!isCancelled(I->Ctx))
+ continue;
+// Cancelled reads are moved to the front of the queue and run
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, javed.absar.
- Reads are never executed if canceled before ready-to run. In practice, we
finalize cancelled reads eagerly and out-of-or
