This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE347298: [clangd] Replay preamble #includes to clang-tidy
checks. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54694?vs=174621&id=174742#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347298: [clangd] Replay preamble #includes to clang-tidy
checks. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54694
Fi
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall added inline comments.
Comment at: clangd/ClangdUnit.cpp:159
+
+ PP.getPPCallbacks()->InclusionDirective(
+ HashTok.getLocation(), IncludeTok, WrittenFilename, Angled,
ilya-biryukov wrote:
> This should be `Delegate->` instead of `PP.getCa
sammccall updated this revision to Diff 174621.
sammccall marked 4 inline comments as done.
sammccall added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54694
Files:
clangd/ClangdUnit.cpp
clangd/Diagnostics.cpp
clangd/Headers.cpp
clangd/He
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:129
+class ReplayPreamble : public PPCallbacks {
+ const IncludeStructure &Includes;
+ PPCallbacks *Delegate;
Maybe move fields and the private function to the end of the class?
We definitel
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
This is needed to correctly handle checks that use IncludeInserter,
which is very common.
I couldn't find a totally safe example of a c
