This revision was automatically updated to reflect the committed changes.
Closed by commit rL347235: [clangd] Store source file hash in IndexFile{In,Out}
(authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D54693?vs=1
kadircet updated this revision to Diff 174635.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54693
Files:
clangd/index/Background.cpp
clangd/index/Serialization.cpp
clangd/index/Seri
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/Serialization.cpp:368
+Reader Hash(Chunks.lookup("hash"));
+llvm::StringRef Digest = Hash.consume(20);
+Result.Digest.emplace()
kadircet updated this revision to Diff 174608.
kadircet marked an inline comment as done.
kadircet added a comment.
- Use digest size instead of hardcoding it.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54693
Files:
clangd/index/Background.cpp
clangd/index/Serialization
jkorous added a comment.
Hi Kadir, I have one small nit otherwise LGTM.
Comment at: clangd/index/Serialization.cpp:368
+Reader Hash(Chunks.lookup("hash"));
+llvm::StringRef Digest = Hash.consume(20);
+Result.Digest.emplace();
Nit: Maybe we could use
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Puts the digest of the source file that generated the index into
serialized index and stores them back on load, if exists.
Repository:
