[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov added a comment. r351334 should fix this. However, this is an indication that libc++ living alongside the compiler (i.e. in `/bin/../include/c++/v1`) cannot be found on PS4. I am not familiar with PS4 myself, but I believe it would be reasonable to assume finding libc++ living alon

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov added a comment. Will take a look. For reference: the particular failing test was added in r351222 (D56680 ), not in this change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ormris added a comment. Hi Ilya, This commit is causing a test failure on the PS4 bot. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/42251 Thanks, Matthew Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov added a comment. D55322 is a review for release notes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54630 ___ cfe-commits mailing l

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

This revision was automatically updated to reflect the committed changes. Closed by commit rC348365: Move detection of libc++ include dirs to Driver on MacOS (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D54630?vs=174358&id=176805#toc Repository: r

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

arphaman added a comment. Please mention this change in the release notes though. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54630 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54630 ___ cfe-commit

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov added a comment. In D54630#1315168 , @arphaman wrote: > So far everything looks fine, but I have to rerun a couple of things due to > infrastructural issues. I should have the final results next Monday. Thanks for the update. Will be waiti

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

arphaman added a comment. So far everything looks fine, but I have to rerun a couple of things due to infrastructural issues. I should have the final results next Monday. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54630

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov added a comment. @arphaman, did you have a chance to run the tests? There's not rush, just wanted to know whether we have any data at all at how Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54630 ___

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov added a comment. In D54630#1308671 , @dexonsmith wrote: > I'm a little skeptical that splitting this logic between cc1 and the driver > will simplify things, but I haven't looked in detail and I'll defer to your > (collective) judgement.

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

dexonsmith added 1 blocking reviewer(s): arphaman. dexonsmith added a comment. In D54630#1308605 , @arphaman wrote: > Sounds convincing. > @dexonsmith What do you think? Besides maintaining correct behaviour, I think the most important thing here is th

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

arphaman added a comment. In D54630#1302566 , @ilya-biryukov wrote: > In D54630#1301283 , @arphaman wrote: > > > I don't think we want to move the logic to add a libc++ path to the driver. > > `-cc1` with `-resour

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

EricWF added a comment. My two cents: I needed something like this when trying to automatically detect if libc++ supported things like sized deallocation, so I would like to see this change go through. (My understanding was that libc++ added a `__libcpp_version` file for just this reason, but

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov added a comment. In https://reviews.llvm.org/D54630#1301283, @arphaman wrote: > I don't think we want to move the logic to add a libc++ path to the driver. > `-cc1` with `-resource-dir` and `-stdlib=libc++` should still work as before. > In this case the previous patch is better,

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ldionne added a comment. In https://reviews.llvm.org/D54630#1301283, @arphaman wrote: > I don't think we want to move the logic to add a libc++ path to the driver. My opinion is not very educated because I don't have a lot of experience/knowledge of Clang, but from my perspective it does make

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

arphaman added a comment. I don't think we want to move the logic to add a libc++ path to the driver. `-cc1` with `-resource-dir` and `-stdlib=libc++` should still work as before. In this case the previous patch is better, except it should not set `InstalledDir` except when needed (e.g. for too

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov created this revision. ilya-biryukov added reviewers: JDevlieghere, arphaman. Herald added a reviewer: EricWF. Herald added subscribers: kadircet, christof, ioeric. The intention is to make the tools replaying compilations from 'compile_commands.json' (clang-tidy, clangd, etc.) find