[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

2018-12-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. When you're doing something but it isn't working, i encourage you to investigate it more pro-actively, or at least add a FIXME so that people didn't think that this is the intended behavior. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2232

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

2018-12-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 176722. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/string.c Index: test/Analysis/string.c

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

2018-12-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. P.S. I guess you can also include the regular `bzero()` here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

2018-12-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ edited reviewers, added: NoQ; removed: dergachev.a. NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2206-2207 + // See if the size argument is zero. + const LocationContext *LCtx = C.getLocationContext(); + SVal SizeVal = State->getSVa

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

2018-12-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping @MaskRay my only hope seemingly :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

2018-11-27 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

2018-11-15 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: george.karpenkov, dergachev.a. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - explicit_bzero has limited scope/usage only for security/crypto purposes but is non-optimisable version of m