[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351105: [clang][UBSan] Sanitization for alignment assumptions. (authored by lebedevri, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://rev

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri updated this revision to Diff 181608. lebedev.ri added a comment. Rebased before commit, NFC. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589 Files: docs/ReleaseNotes.rst docs/UndefinedBehaviorSanitizer.rst

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri updated this revision to Diff 179272. lebedev.ri added a comment. Rebased, NFC. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589 Files: docs/ReleaseNotes.rst docs/UndefinedBehaviorSanitizer.rst lib/CodeGen

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589 ___ cfe-commi

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri added a comment. In D54589#1309929 , @rjmccall wrote: > LGTM. Thank you for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri updated this revision to Diff 175494. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Address @rjmccall review notes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589 Files: docs/Relea

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

rjmccall added inline comments. Comment at: docs/ReleaseNotes.rst:310 + char **passthrough(__attribute__((align_value(1024))) char **x) { +return x; // <- check the + } unfinished Comment at: docs/UndefinedBehaviorSanitizer.rs

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri updated this revision to Diff 175407. lebedev.ri marked 11 inline comments as done. lebedev.ri added a comment. Address @rjmccall review notes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589 Files: docs/Rele

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri marked an inline comment as not done. lebedev.ri added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:198 +assume-aligned-like attributes), `object-size``, and ``vptr`` checks do not +apply to pointers to types with the ``volatile`` qualifier --

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:198 +assume-aligned-like attributes), `object-size``, and ``vptr`` checks do not +apply to pointers to types with the ``volatile`` qualifier --

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

rjmccall added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:198 +assume-aligned-like attributes), `object-size``, and ``vptr`` checks do not +apply to pointers to types with the ``volatile`` qualifier lebedev.ri wrote: > rjmccall wrote: > >

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:198 +assume-aligned-like attributes), `object-size``, and ``vptr`` checks do not +apply to pointers to types with the ``volatile`` qualifier rjmccall wrote: > Is there a reason fo

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

rjmccall added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:75 - ``-fsanitize=alignment``: Use of a misaligned pointer or creation - of a misaligned reference. + of a misaligned reference. Also sanitizes assume-aligned-like attributes. - ``-fsa

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri updated this revision to Diff 174451. lebedev.ri added a comment. Adapt to https://reviews.llvm.org/D54588 no longer providing the actual pointer. The handled itself will have to deal with subtracting the offset. Repository: rC Clang https://reviews.llvm.org/D54589 Files: docs/R

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri created this revision. lebedev.ri added reviewers: ABataev, craig.topper, vsk, rsmith, rnk, Sanitizers, erichkeane, filcab, rjmccall. lebedev.ri added a project: Sanitizers. lebedev.ri added a dependency: D54588: [llvm][IRBuilder] Introspection for CreateAlignmentAssumption*() function