[PATCH] D54576: [clang] - Simplify tools::SplitDebugName.

2018-11-16 Thread George Rimar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347035: [clang] - Simplify tools::SplitDebugName. (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54576?vs=174193&id=1743

[PATCH] D54576: [clang] - Simplify tools::SplitDebugName.

2018-11-15 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Agreed - looks like this went in untested in r175813 & has never been used. https://reviews.llvm.org/D54576 ___ cfe-commits mailing list cfe-

[PATCH] D54576: [clang] - Simplify tools::SplitDebugName.

2018-11-15 Thread George Rimar via Phabricator via cfe-commits
grimar created this revision. grimar added a reviewer: dblaikie. grimar added a comment. `SplitDebugName` is called from the following 4 places: 1. void Clang::ConstructJob() (https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/Clang.cpp#L3933) We can get here when clang cons

[PATCH] D54576: [clang] - Simplify tools::SplitDebugName.

2018-11-15 Thread George Rimar via Phabricator via cfe-commits
grimar added a comment. `SplitDebugName` is called from the following 4 places: 1. void Clang::ConstructJob() (https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/Clang.cpp#L3933) We can get here when clang construct jobs for regular case (cpp files): EX: main.cpp -g -gsplit-