This revision was automatically updated to reflect the committed changes.
Closed by commit rC346954: [AST] Pack BinaryOperator (authored by brunoricci,
committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D54526
Files:
include/clang/AST/Expr.h
include/clang/AST/Stmt.h
Index: inc
riccibruno marked 6 inline comments as done.
riccibruno added a comment.
Marked the inline comments as done since I believe I
answered each of them. If not I can fix it in a subsequent commit.
Repository:
rC Clang
https://reviews.llvm.org/D54526
riccibruno marked an inline comment as done.
riccibruno added a comment.
Added some inline comments.
Comment at: include/clang/AST/Expr.h:3220
- SourceLocation getExprLoc() const LLVM_READONLY { return OpLoc; }
- SourceLocation getOperatorLoc() const { return OpLoc; }
- vo
dblaikie added inline comments.
Comment at: include/clang/AST/Stmt.h:572
CastExprBitfields CastExprBits;
+BinaryOperatorBitfields BinaryOperatorBits;
InitListExprBitfields InitListExprBits;
Oh, just a thought - wonder if we could/should have an asse
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good - thanks! just a few things that could be cleaned up.
Comment at: include/clang/AST/Expr.h:3220
- SourceLocation getExprLoc() const LLVM_READONLY { return O
riccibruno created this revision.
riccibruno added a reviewer: dblaikie.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.
Use the newly available space in the bit-fields of `Stmt`.
This saves 8 bytes per `BinaryOperator`.
Repository:
rC Clang
https://reviews.llvm.org
