This revision was automatically updated to reflect the committed changes.
Closed by commit rC346953: [AST] Pack MemberExpr (authored by brunoricci,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54525?vs=174026&id=174196#toc
Repository:
rC Clang
https://reviews.llvm.org/
riccibruno added inline comments.
Comment at: include/clang/AST/Expr.h:2802
- friend class ASTReader;
- friend class ASTStmtWriter;
};
Having this at the bottom is so painful for the reader,
and people seems to put them at the top of the class usually.
But yes
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good - thanks!
Comment at: include/clang/AST/Expr.h:2799-2802
-
- friend TrailingObjects;
- friend class ASTReader;
- friend class ASTStmtWriter;
---
riccibruno created this revision.
riccibruno added a reviewer: dblaikie.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.
Use the newly available space in the bit-fields of `Stmt`
to store some data from `MemberExpr`. This saves
one pointer per `MemberExpr`.
Repository:
