[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348198: [AST] Generate unique identifiers for CXXCtorInitializer objects. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

2018-12-03 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 176470. NoQ added a comment. Wait, i already did that in D54488 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54457/new/ https://reviews.llvm.org/D54457 Files: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp Ind

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

2018-12-03 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 176465. NoQ added a comment. Rebase on top of D54486 ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54457/new/ https://reviews.llvm.org/D54457 Files: include/clang/AST/DeclCXX.h lib/AST/DeclBase.cpp lib/AST/DeclC

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

2018-11-12 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov accepted this revision. george.karpenkov added inline comments. This revision is now accepted and ready to land. Comment at: lib/AST/DeclCXX.cpp:2249 +int64_t CXXCtorInitializer::getID(const ASTContext &Context) const { + Optional Out = Context.getAllocator().

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

2018-11-12 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: george.karpenkov, rsmith. Herald added a subscriber: cfe-commits. This follows https://reviews.llvm.org/D51822 and https://reviews.llvm.org/D52113 to add a cheap way of obtaining a unique and relatively stable* numeric identifier for `CXXCtorInitia