[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

sammccall added a comment. Sorry for not getting back to this, but it looks good. I'm really glad about how minimal the changes are outside xpc/, because it makes it less likely we'll accidentally break something that can only be tested on mac. Repository: rCTE Clang Tools Extra CHANGES SI

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

MaskRay added a comment. In D54428#1359333 , @tamur wrote: > This patch seems to have broken the compilation. I get the following error on > a linux platform: > [12/14] Linking CXX executable bin/clangd > FAILED: bin/clangd > : && > /usr/local/google

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

tamur added a comment. This patch seems to have broken the compilation. I get the following error on a linux platform: [12/14] Linking CXX executable bin/clangd FAILED: bin/clangd : && /usr/local/google/home/tamur/src/llvm/2018_nov_12/llvm/Stable/bin/clang++ -fPIC -fvisibility-inlines-hidden -

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351280: [clangd] XPC transport layer (authored by jkorous, committed by ). Changed prior to commit: https://reviews.llvm.org/D54428?vs=180809&id=181925#toc Repository: rCTE Clang Tools Extra CHANG

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54428/new/ https://reviews.llvm.org/D54428 ___ cfe-commits mailing list cfe-commi

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

jkorous updated this revision to Diff 180809. jkorous edited the summary of this revision. jkorous added a comment. Fixed the synchronous handling of events. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54428/new/ https://reviews.llvm.org/D54428 Files: CMakeLists.txt clangd/CMakeL

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

jkorous added a comment. @arphaman or @sammccall, could you please take the final look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54428/new/ https://reviews.llvm.org/D54428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

jkorous updated this revision to Diff 180640. jkorous retitled this revision from "[clangd][WIP] XPC transport layer, framework, test-client" to "[clangd] XPC transport layer, framework, test-client". jkorous edited the summary of this revision. jkorous added a comment. added one more assert R

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

jkorous planned changes to this revision. jkorous added a comment. In https://reviews.llvm.org/D54428#1297147, @sammccall wrote: > A question about the high-level build target setup (I don't know much about > XPC services/frameworks, bear with me...): > > This is set up so that the clangd binary

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

sammccall added a comment. A question about the high-level build target setup (I don't know much about XPC services/frameworks, bear with me...): This is set up so that the clangd binary (ClangdMain) can run unmodified as an XPC service, all flags and options are still respected etc. At the sam

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

jkorous created this revision. jkorous added reviewers: arphaman, sammccall. Herald added subscribers: cfe-commits, kadircet, dexonsmith, MaskRay, ioeric, ilya-biryukov, mgorny. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54428 Files: CMakeLists.txt Features.inc.in clan