This revision was automatically updated to reflect the committed changes.
Closed by commit rL34: [clangd] Allow symbols from AnyScope in dexp.
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54427
Files:
clang-t
hokein added inline comments.
Comment at: clangd/index/dex/dexp/Dexp.cpp:55
FuzzyFindRequest Request;
+ Request.AnyScope = true;
// Remove leading "::" qualifier as FuzzyFind doesn't need leading "::"
ioeric wrote:
> I don't think you would want AnyScope h
hokein updated this revision to Diff 173676.
hokein marked 2 inline comments as done.
hokein added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54427
Files:
clangd/index/dex/dexp/Dexp.cpp
Index: clangd/index/dex/dexp/Dexp.cpp
=
ioeric added inline comments.
Comment at: clangd/index/dex/dexp/Dexp.cpp:55
FuzzyFindRequest Request;
+ Request.AnyScope = true;
// Remove leading "::" qualifier as FuzzyFind doesn't need leading "::"
I don't think you would want AnyScope here. For example
hokein created this revision.
hokein added a reviewer: ioeric.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
We should allow symbols from any scope in dexp results, othewise
`find StringRef` doesn't return any results (llvm::StringRef).
Repository:
rCTE Clang T
