[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

shuaiwang added a comment. In D54399#1391975 , @lebedev.ri wrote: > In D54399#1391935 , @shuaiwang wrote: > > > Hi @rsmith what do you think of just get this in since Eric is not > > responding? Or do you think I s

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

lebedev.ri added a comment. In D54399#1391935 , @shuaiwang wrote: > Hi @rsmith what do you think of just get this in since Eric is not > responding? Or do you think I should run certain test to verify? I'm having a déjà vu. Wasn't there already an attem

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

shuaiwang added a comment. Herald added a project: clang. Hi @rsmith what do you think of just get this in since Eric is not responding? Or do you think I should run certain test to verify? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54399/new/ https://reviews

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

shuaiwang added a comment. Friendly ping @EricWF Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54399/new/ https://reviews.llvm.org/D54399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

shuaiwang added a comment. In https://reviews.llvm.org/D54399#1296317, @dblaikie wrote: > Could you fix the modulemap (might amount to reverting the change Eric made > in r342827? or maybe it's more involved than that) & validate that the > modules build is working with this change (probably un

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

dblaikie added a comment. Could you fix the modulemap (might amount to reverting the change Eric made in r342827? or maybe it's more involved than that) & validate that the modules build is working with this change (probably undo Eric's change, validate that you see the breakage that Eric was t

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

JonasToth added a comment. Will you update the existing clang-tidy checks as well? Repository: rC Clang https://reviews.llvm.org/D54399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

shuaiwang created this revision. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, a.sidorin, mgorny. Herald added a reviewer: george.karpenkov. This just copies ExprMutationAnalyzer to Tooling/Analysis with minor tweaks around including path & namespaces. 2/3 will change exi