This revision was automatically updated to reflect the committed changes.
Closed by commit rL347036: [clangd] Initial clang-tidy diagnostics support.
(authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54204
Files:
c
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
sammccall updated this revision to Diff 174204.
sammccall added a comment.
Remove clang-tidy changes, add FIXME comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54204
Files:
clangd/CMakeLists.txt
clangd/ClangdUnit.cpp
clangd/XRefs.cpp
unittests/clangd/ClangdUnitT
sammccall added a comment.
Moved the clang-tidy changes to https://reviews.llvm.org/D54579.
Sorry for mixing everything up!
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:518
void SimplifyBooleanExprCheck::registerMatchers(MatchFinder *Finder) {
- Finder->add
hokein added a comment.
Looks mostly good, just a few nits.
This patch contains two parts (clang-tidy and clangd), I think we could split
into two, but I'm not insisting, up to you.
Comment at: clang-tidy/modernize/LoopConvertUtils.h:59
/// \brief Run the analysis on th
sammccall added inline comments.
Comment at: clangd/ClangdUnit.cpp:175
+CTFactories.createChecks(CTContext.getPointer(), CTChecks);
+for (const auto &Check : CTChecks) {
+ Check->registerPPCallbacks(*Clang);
hokein wrote:
> Maybe add the check names
sammccall updated this revision to Diff 173357.
sammccall marked an inline comment as done.
sammccall added a comment.
Address comments and rebase on https://reviews.llvm.org/D54309, addressing
performance issues.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54204
Files:
c
hokein added a comment.
I think this is in a good shape as initial patch!
Comment at: clangd/ClangdUnit.cpp:168
+// The placeholder check here does not use hasAncestor() so is unaffected.
+CTOpts.Checks = "bugprone-sizeof-expression";
+CTContext.emplace(llvm::make_u
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov, mgorny, srhines.
This runs checks over a restricted subset of the TU:
- preprocessor callbacks just receive the truncated PP ev
