This revision was automatically updated to reflect the committed changes.
Closed by commit rL346319: [clangd] Drop namespace references in the index.
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54202
Files:
clan
hokein updated this revision to Diff 172950.
hokein marked an inline comment as done.
hokein added a comment.
Fix another typo.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54202
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests/clangd/Sym
hokein added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:359
return true;
- if (CollectRef &&
+ if (CollectRef && !isa(ND) &&
(Opts.RefsInHeaders || SM.getFileID(SpellingLoc) == SM.getMainFileID()))
kadircet wrote:
> Why not handle
kadircet added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:359
return true;
- if (CollectRef &&
+ if (CollectRef && !isa(ND) &&
(Opts.RefsInHeaders || SM.getFileID(SpellingLoc) == SM.getMainFileID()))
Why not handle in `shouldColle
hokein updated this revision to Diff 172926.
hokein added a comment.
Fix a typo.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54202
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests/clangd/SymbolCollectorTests.cpp
Index: unittests/clangd
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Namespace references is less useful compared with other symbols, and
they contribute large part of the index. This patch drops them.
The number
