[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

This revision was automatically updated to reflect the committed changes. Closed by commit rC347677: Fix linker option for -fprofile-arcs -ftest-coverage (authored by marco, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54195/new/ https://reviews.l

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

jessicah added a comment. I don't have commit permission to Clang review, can somebody commit this for me? Thanks, Jessica Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54195/new/ https://reviews.llvm.org/D54195 ___

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

vsk added a comment. @jessicah Please ping this review if you need someone to commit this patch on your behalf. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54195/new/ https://reviews.llvm.org/D54195 ___ cfe-commit

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

jessicah updated this revision to Diff 174076. jessicah added a comment. Update test case for "--coverage" upon review comments. Repository: rC Clang https://reviews.llvm.org/D54195 Files: lib/Driver/ToolChains/Linux.cpp test/Driver/clang_f_opts.c Index: test/Driver/clang_f_opts.c

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

marco-c accepted this revision. marco-c added a comment. This revision is now accepted and ready to land. Thanks! Comment at: test/Driver/clang_f_opts.c:89 +// RUN: %clang -### -fprofile-arcs -ftest-coverage %s 2>&1 | FileCheck -check-prefix=CHECK-u %s +// CHECK-u-NOT: "-u{{.*

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

jessicah updated this revision to Diff 173209. jessicah added a comment. Updated diff with additional context upon review comments. Repository: rC Clang https://reviews.llvm.org/D54195 Files: lib/Driver/ToolChains/Linux.cpp test/Driver/clang_f_opts.c Index: test/Driver/clang_f_opts.c =

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

vsk added a comment. Thanks for the patch. Would you mind uploading a diff with additional context (e.g. git diff -U1)? Phab doesn't render it. Repository: rC Clang https://reviews.llvm.org/D54195 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

jessicah created this revision. Herald added a subscriber: cfe-commits. Linux toolchain accidentally added "-u__llvm_runtime_variable" when "-fprofile-arcs -ftest-coverage", this is not added when "--coverage" option is used. Using "-u__llvm_runtime_variable" generates an empty default.profraw f