[PATCH] D54171: [MS] Zero out ECX in __cpuid in intrin.h

2018-11-07 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Thanks for fixing! Repository: rL LLVM https://reviews.llvm.org/D54171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54171: [MS] Zero out ECX in __cpuid in intrin.h

2018-11-06 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL346265: [MS] Zero out ECX in __cpuid in intrin.h (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54171?vs=172811&id=172831#t

[PATCH] D54171: [MS] Zero out ECX in __cpuid in intrin.h

2018-11-06 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D54171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D54171: [MS] Zero out ECX in __cpuid in intrin.h

2018-11-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added reviewers: craig.topper, hans. Some CPUID leafs depend on the value of ECX as well as EAX, but we left it uninitialized. Originally reported as https://crbug.com/901547 https://reviews.llvm.org/D54171 Files: clang/lib/Headers/intrin.h clang/test/CodeGen