[PATCH] D54156: [CodeComplete] Do not complete self-initializations

2018-11-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL346301: [CodeComplete] Do not complete self-initializations (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54156 Files:

[PATCH] D54156: [CodeComplete] Do not complete self-initializations

2018-11-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. :-) Repository: rC Clang https://reviews.llvm.org/D54156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D54156: [CodeComplete] Do not complete self-initializations

2018-11-06 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 172773. ilya-biryukov added a comment. - Remove std::move, the target is const ref, so it does nothing (thanks, clang-tidy!) Repository: rC Clang https://reviews.llvm.org/D54156 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/ordinary

[PATCH] D54156: [CodeComplete] Do not complete self-initializations

2018-11-06 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a subscriber: arphaman. Removes references to initialized variable from the following completions: int x = ^; Handles only the trivial cases where the variable name is completed immediately at the star