[PATCH] D54132: [CodeGenCXX] XFAIL test for ASAN on Darwin.

2018-11-05 Thread Volodymyr Sapsai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC346200: [CodeGenCXX] XFAIL test for ASAN on Darwin. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D54132?vs=172692&id=172699#toc Repository: rC Clang https:

[PATCH] D54132: [CodeGenCXX] XFAIL test for ASAN on Darwin.

2018-11-05 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov accepted this revision. george.karpenkov added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp:8 +// recursive template instantiation limit. +// XFAIL: darwin && asan + --

[PATCH] D54132: [CodeGenCXX] XFAIL test for ASAN on Darwin.

2018-11-05 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added inline comments. Comment at: clang/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp:8 +// recursive template instantiation limit. +// XFAIL: darwin && asan + george.karpenkov wrote: > Do we actually want UNSUPPORTED here? We don't want to fail if

[PATCH] D54132: [CodeGenCXX] XFAIL test for ASAN on Darwin.

2018-11-05 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added inline comments. Comment at: clang/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp:8 +// recursive template instantiation limit. +// XFAIL: darwin && asan + Do we actually want UNSUPPORTED here? We don't want to fail if ASAN stack usage

[PATCH] D54132: [CodeGenCXX] XFAIL test for ASAN on Darwin.

2018-11-05 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai created this revision. vsapsai added reviewers: george.karpenkov, lebedev.ri. Herald added a subscriber: dexonsmith. The test hits stack overflow trying to instantiate recursive templates. It is observed with ASAN and not with a regular build because ASAN increases stack frame size. rdar: