This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE346219: [clang-tidy] run() doesn't update the
SourceManager. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54061?vs=172471&id=172719#toc
Repository:
rCT
JonasToth added a comment.
In https://reviews.llvm.org/D54061#1288395, @sammccall wrote:
> In https://reviews.llvm.org/D54061#1286956, @JonasToth wrote:
>
> > > Theoretically, we could replace `ClangTidyCheck::check` with
> > > `ClangTidyCheck::run`, but I'm not sure it is worth,
> > > `ClangTi
sammccall added a comment.
In https://reviews.llvm.org/D54061#1286956, @JonasToth wrote:
> > Theoretically, we could replace `ClangTidyCheck::check` with
> > `ClangTidyCheck::run`, but I'm not sure it is worth,
> > `ClangTidyCheck::check` is a public API, and is widely-used (for all
> > clang-
JonasToth added a comment.
> Theoretically, we could replace `ClangTidyCheck::check` with
> `ClangTidyCheck::run`, but I'm not sure it is worth, `ClangTidyCheck::check`
> is a public API, and is widely-used (for all clang-tidy checks), replacing it
> requires large changes (although it is one-l
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The change looks reasonable to me.
In https://reviews.llvm.org/D54061#1286505, @steveire wrote:
> After this change, it seems that `ClangTidyCheck::check` is not needed and
> all callers shou
steveire added a comment.
After this change, it seems that `ClangTidyCheck::check` is not needed and all
callers should be ported to call `run()` instead (and the private `run()`
declaration should be removed from `ClangTidyCheck`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org
sammccall created this revision.
sammccall added reviewers: hokein, alexfh.
Herald added subscribers: cfe-commits, xazax.hun.
By now the context's SourceManager is now initialized everywhere that
ClangTidyCheck::registerMatcher() is called, so the call from run() seems
entirely redundant, and inde
