[PATCH] D54047: Check TUScope is valid before use

2021-06-07 Thread Kim Gräsman via Phabricator via cfe-commits
kimgr added a comment. This was eventually fixed in IWYU based on @jkorous' suggestion above. I believe the problem is/was: - After code is parsed and the AST is built, Sema resets its `TUScope` member to null - We use Sema to lookup and define default constructors before traversing the AST us

[PATCH] D54047: Check TUScope is valid before use

2018-11-19 Thread Jan Korous via Phabricator via cfe-commits
jkorous added reviewers: rjmccall, doug.gregor. jkorous added subscribers: rjmccall, doug.gregor. jkorous added a comment. Adding @rjmccall and @doug.gregor who might have some insight. Honestly, I don't know how IWYU works and my familiarity with Sema is limited so bear with me. From what I se

[PATCH] D54047: Check TUScope is valid before use

2018-11-16 Thread Kim Gräsman via Phabricator via cfe-commits
kimgr added subscribers: zturner, kimgr. kimgr added a comment. Here's some related suggestions/questions for context: - Earlier patch from @zturner with a minimal repro case: https://reviews.llvm.org/D31697. I don't think this is reproducible with Clang proper. - Open question for alternative

[PATCH] D54047: Check TUScope is valid before use

2018-11-16 Thread Tom Rix via Phabricator via cfe-commits
trixirt added a comment. Since the crash happens with the iwyu tool, a bit ago i added the testcase at the iwyu project here. https://github.com/include-what-you-use/include-what-you-use/pull/601 I don't know if it makes sense to run iwyu from clang/test. Repository: rC Clang https://review

[PATCH] D54047: Check TUScope is valid before use

2018-11-16 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. Could you please add a test? I'd suggest minimizing the testcase you linked and placing it to `clang/test`. Repository: rC Clang https://reviews.llvm.org/D54047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D54047: Check TUScope is valid before use

2018-11-02 Thread Tom Rix via Phabricator via cfe-commits
trixirt created this revision. trixirt added reviewers: rsmith, stephenkelly. Herald added a subscriber: cfe-commits. Include-what-you-use crashes when run against llvm because of late use of TUScope. The testcase is https://github.com/trixirt/include-what-you-use/commit/dfec8cf07015fb5fe2db10df