This revision was automatically updated to reflect the committed changes.
Closed by commit rL345729: Delete dependency on config.h (authored by kadircet,
committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53935
Files:
clang-tools-extra/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345729: Delete dependency on config.h (authored by
kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53935?vs=171931&id=171933#toc
Repository:
rL LLVM
https://reviews.ll
sammccall added a comment.
In https://reviews.llvm.org/D53935#1282303, @lebedev.ri wrote:
> How does this play with `LLVM_ENABLE_THREADS` cmake option?
Clangd doesn't support/respect that, and I don't think anyone's building in
that configuration.
If this causes actual problems e.g. with bots,
kadircet updated this revision to Diff 171931.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53935
Files:
clangd/Threading.cpp
Index: clangd/Threading.cpp
=
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/Threading.cpp:7
#include
-#ifdef HAVE_PTHREAD_H
+#if defined(__USE_POSIX)
#include
nit: just ifdef?
Repository:
rCTE Cla
sammccall added inline comments.
Comment at: clangd/Threading.cpp:104
void setThreadPriority(std::thread &T, ThreadPriority Priority) {
-#if defined(HAVE_PTHREAD_H) && defined(__linux__)
+#if defined(__USE_POSIX) && defined(__linux__)
sched_param priority;
th
lebedev.ri added a comment.
How does this play with `LLVM_ENABLE_THREADS` cmake option?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, ioeric,
ilya-biryukov, krytarowski.
Since llvm/Config/config.h is not available on standalone builds,
use __USE_POSIX instead of HAVE_PTHREAD_H and get rid of the i
