This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE346223: [clangd] Get rid of QueryScopes.empty() ==
AnyScope special case. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53933?vs=172735&id=172737#toc
Reposit
ioeric updated this revision to Diff 172735.
ioeric added a comment.
- rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53933
Files:
clangd/FindSymbols.cpp
clangd/index/Index.h
clangd/index/MemIndex.cpp
clangd/index/dex/Dex.cpp
unittests/clangd/DexTests.cpp
uni
ioeric updated this revision to Diff 172591.
ioeric marked an inline comment as done.
ioeric added a comment.
- Remove addressed FIXME.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53933
Files:
clangd/FindSymbols.cpp
clangd/index/Index.h
clangd/index/MemIndex.cpp
clan
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Yay, thanks!
Comment at: clangd/index/Index.h:463
/// The global scope is "", a top level scope is "foo::", etc.
- /// FIXME: drop the special case for empty list,
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53933
Files:
clangd/FindSymbols.cpp
clangd/index/Index.h
clangd/inde
