This revision was automatically updated to reflect the committed changes.
Closed by commit rC346455: Compound literals, enums, et al require const expr
(authored by void, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53921?vs=172313&id=173248#toc
Repository:
rC Clang
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346455: Compound literals, enums, et al require const expr
(authored by void, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53921?vs=172313&
void marked an inline comment as done.
void added a comment.
I'm using "arcanist" for the first time, and I don't want to mess things up.
I'll address the comments here in the next patch.
Repository:
rC Clang
https://reviews.llvm.org/D53921
___
void marked 2 inline comments as done.
void added inline comments.
Comment at: include/clang/AST/Expr.h:3073-3074
+ e = ice->getSubExpr();
+else if (ConstantExpr *ce = dyn_cast(e))
+ e = ce->getSubExpr();
+else
rsmith wrote:
> Should we skip an
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, other than the compound literal part I think this is all fine. I'm
happy for you to go ahead with this as-is; we can rearrange how we handle
compound literals as a later change if you
void updated this revision to Diff 172313.
Repository:
rC Clang
https://reviews.llvm.org/D53921
Files:
include/clang/AST/Expr.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTImporter.cpp
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/ASTMatchers/ASTMatchersInternal.cpp
lib/AS
void updated this revision to Diff 172297.
Repository:
rC Clang
https://reviews.llvm.org/D53921
Files:
include/clang/AST/Expr.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTImporter.cpp
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/ASTMatchers/ASTMatchersInternal.cpp
lib/AS
void updated this revision to Diff 172279.
void retitled this revision from "Compound literals, global array decls, and
enums require constant inits" to "Compound literals, enums, et al require const
expr".
void edited the summary of this revision.
void added a comment.
I believe this patch shou
