[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

NoQ added a comment. In https://reviews.llvm.org/D53856#1285373, @rnkovacs wrote: > In https://reviews.llvm.org/D53856#1280408, @Szelethus wrote: > > > In https://reviews.llvm.org/D53856#1279887, @NoQ wrote: > > > > > This might be also covered by @rnkovacs's string buffer escape checker - > > >

[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

This revision was automatically updated to reflect the committed changes. Closed by commit rC345990: [analyzer] Put llvm.Conventions back in alpha (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D53856?vs=172253&id=172380#toc Repository: rC Clang ht

[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

This revision was automatically updated to reflect the committed changes. Closed by commit rL345990: [analyzer] Put llvm.Conventions back in alpha (authored by Szelethus, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53856?vs=172253&

[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

rnkovacs added a comment. In https://reviews.llvm.org/D53856#1280408, @Szelethus wrote: > In https://reviews.llvm.org/D53856#1279887, @NoQ wrote: > > > This might be also covered by @rnkovacs's string buffer escape checker - > > either already or eventually, it'll become just yet another string

[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

Szelethus updated this revision to Diff 172253. Szelethus added a comment. - Moved `std::string` implementation from `InnerPointerChecker`'s testfile to the system header simulator header file. https://reviews.llvm.org/D53856 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/Sta

[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

Szelethus added a comment. In https://reviews.llvm.org/D53856#1279887, @NoQ wrote: > This might be also covered by @rnkovacs's string buffer escape checker - > either already or eventually, it'll become just yet another string view API > that the checker supports. I thought about that too, ad

[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

MTC added a comment. In addition, `clang/lib/StaticAnalyzer/README.txt` and other related docs in `clang/lib/docs/analyzer` are also out of date. Comment at: www/analyzer/alpha_checks.html:570 + + A StringRef should not be bound to a temporary std::string + whose lifetime i

[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I've actually never noticed this checker until you started updating the website :) This might be also covered by @rnkovacs's string buffer escape checker - either already or eventually, it'll becom

[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp:193-195 static bool AllocatesMemory(QualType T) { return IsStdVector(T) || IsStdString(T) || IsSmallVector(T); } The `StringRef`part of this checker doesn't d

[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

Szelethus updated this revision to Diff 171623. Szelethus added a comment. Added an entry to the website. https://reviews.llvm.org/D53856 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp test/Analysis/llvm-conventions.cpp ww

[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, MTC. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Interestingly, this many year old (when I last looked I remember 2010ish) checke