This revision was automatically updated to reflect the committed changes.
Closed by commit rL348978: Declares __cpu_model as dso local (authored by hhb,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53850?vs=171789&id=177915#toc
Rep
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53850/new/
https://reviews.llvm.org/D53850
___
cf
srhines added a comment.
Craig, does this look ok now?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53850/new/
https://reviews.llvm.org/D53850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
hhb added a comment.
Anyone can have a look at this change?
Repository:
rC Clang
https://reviews.llvm.org/D53850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hhb added a comment.
Ping..
Repository:
rC Clang
https://reviews.llvm.org/D53850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hhb added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:9013
Features, llvm::ConstantInt::get(Int32Ty, FeaturesMask));
return Builder.CreateICmpNE(Bitset, llvm::ConstantInt::get(Int32Ty, 0));
}
craig.topper wrote:
> This code looks to be out o