rjmccall added inline comments.
Comment at: cfe/trunk/lib/CodeGen/CGExpr.cpp:4268
+DestTy.getAddressSpace(), ConvertType(DestTy));
+return MakeNaturalAlignPointeeAddrLValue(V, DestTy);
+ }
romanovvlad wrote:
> Hi,
>
> It seems this code doesn't work
romanovvlad added inline comments.
Comment at: cfe/trunk/lib/CodeGen/CGExpr.cpp:4268
+DestTy.getAddressSpace(), ConvertType(DestTy));
+return MakeNaturalAlignPointeeAddrLValue(V, DestTy);
+ }
Hi,
It seems this code doesn't work correctly(repro at th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347059: [OpenCL] Enable address spaces for references in C++
(authored by stulova, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53764?vs=17
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D53764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Anastasia marked 4 inline comments as done.
Anastasia added a comment.
Do you think there is anything else to do for this patch?
Comment at: lib/Sema/SemaExprCXX.cpp:4289
+ /*BasePath=*/nullptr, CCK)
+ .get();
rjmccal
rjmccall added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4289
+ /*BasePath=*/nullptr, CCK)
+ .get();
Anastasia wrote:
> rjmccall wrote:
> > Anastasia wrote:
> > > rjmccall wrote:
> > > > Anastasia wrote:
> >
Anastasia added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4289
+ /*BasePath=*/nullptr, CCK)
+ .get();
rjmccall wrote:
> Anastasia wrote:
> > rjmccall wrote:
> > > Anastasia wrote:
> > > > rjmccall wrote:
> >
rjmccall added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4289
+ /*BasePath=*/nullptr, CCK)
+ .get();
Anastasia wrote:
> rjmccall wrote:
> > Anastasia wrote:
> > > rjmccall wrote:
> > > > Okay. But if `ToTyp
Anastasia added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4289
+ /*BasePath=*/nullptr, CCK)
+ .get();
rjmccall wrote:
> Anastasia wrote:
> > rjmccall wrote:
> > > Okay. But if `ToType` *isn't* a reference t
Anastasia updated this revision to Diff 174033.
Anastasia added a comment.
Fixed check for AS mismatch of pointer type and added missing test case
https://reviews.llvm.org/D53764
Files:
include/clang/Sema/Sema.h
lib/AST/Expr.cpp
lib/CodeGen/CGExpr.cpp
lib/Sema/DeclSpec.cpp
lib/Sema/Se
rjmccall added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4289
+ /*BasePath=*/nullptr, CCK)
+ .get();
Anastasia wrote:
> rjmccall wrote:
> > Okay. But if `ToType` *isn't* a reference type, this will never be
Anastasia added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4289
+ /*BasePath=*/nullptr, CCK)
+ .get();
rjmccall wrote:
> Okay. But if `ToType` *isn't* a reference type, this will never be an
> address-space
Anastasia updated this revision to Diff 173873.
Anastasia added a comment.
Rewrite how CastKind is set for reference and pointer type.
https://reviews.llvm.org/D53764
Files:
include/clang/Sema/Sema.h
lib/AST/Expr.cpp
lib/CodeGen/CGExpr.cpp
lib/Sema/DeclSpec.cpp
lib/Sema/SemaDecl.cpp
rjmccall added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4289
+ /*BasePath=*/nullptr, CCK)
+ .get();
Okay. But if `ToType` *isn't* a reference type, this will never be an
address-space conversion. I feel
Anastasia updated this revision to Diff 173693.
Anastasia marked an inline comment as done.
Anastasia added a comment.
- Extended assert
- Handled AS of ToType
https://reviews.llvm.org/D53764
Files:
include/clang/Sema/Sema.h
lib/AST/Expr.cpp
lib/CodeGen/CGExpr.cpp
lib/Sema/DeclSpec.cp
rjmccall added inline comments.
Comment at: lib/AST/Expr.cpp:1609
case CK_AddressSpaceConversion:
-assert(getType()->isPointerType() || getType()->isBlockPointerType());
-assert(getSubExpr()->getType()->isPointerType() ||
- getSubExpr()->getType()->isBlockPoi
Anastasia updated this revision to Diff 173334.
Anastasia added a comment.
Changed the assert for address space conversion.
https://reviews.llvm.org/D53764
Files:
include/clang/Sema/Sema.h
lib/AST/Expr.cpp
lib/CodeGen/CGExpr.cpp
lib/Sema/DeclSpec.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/S
rjmccall added inline comments.
Comment at: lib/AST/Expr.cpp:1609
case CK_AddressSpaceConversion:
-assert(getType()->isPointerType() || getType()->isBlockPointerType());
-assert(getSubExpr()->getType()->isPointerType() ||
- getSubExpr()->getType()->isBlockPoi
Anastasia updated this revision to Diff 172109.
Anastasia added a comment.
Addressed comments from John.
https://reviews.llvm.org/D53764
Files:
include/clang/Sema/Sema.h
lib/AST/Expr.cpp
lib/CodeGen/CGExpr.cpp
lib/Sema/DeclSpec.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExprCXX.cpp
li
rjmccall added inline comments.
Comment at: lib/AST/Expr.cpp:1609
case CK_AddressSpaceConversion:
-assert(getType()->isPointerType() || getType()->isBlockPointerType());
-assert(getSubExpr()->getType()->isPointerType() ||
- getSubExpr()->getType()->isBlockPoi
Anastasia added inline comments.
Comment at: lib/AST/Expr.cpp:1609
case CK_AddressSpaceConversion:
-assert(getType()->isPointerType() || getType()->isBlockPointerType());
-assert(getSubExpr()->getType()->isPointerType() ||
- getSubExpr()->getType()->isBlockPo
Anastasia created this revision.
Anastasia added reviewers: rjmccall, yaxunl.
I first enabled AS deduction for references that allowed to inherit the right
conversion diagnostics based on qualification conversion rules implemented
earlier for the pointer type.
Then in order to tests the deducti
22 matches
Mail list logo
