[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

Anastasia added a comment. Herald added a subscriber: ebevhan. Herald added a project: clang. Btw, I have created a patch that allows non-underscore prefixed spelling for address spaces in C++ for OpenCL: https://reviews.llvm.org/D59603 I assume the error becomes less critical however it remains

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

rjmccall added a comment. I'm just concerned about adding a great deal of complexity to mainline Clang in order to support a language that might still be in major flux and which I feel is likely to be forced to re-embrace qualifiers in the language model. Maybe this work should happen in a bra

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

keryell added a comment. In https://reviews.llvm.org/D53705#1285096, @rjmccall wrote: > > If your plan is to compile code for the CPU with a normal C++ compiler but > for the GPU with an OpenCL-aware compiler, you are going to have > significantly divergent behavior between the CPU and GPU

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

rjmccall added a comment. In https://reviews.llvm.org/D53705#1284734, @keryell wrote: > In https://reviews.llvm.org/D53705#1284268, @rjmccall wrote: > > > > > > > > > Okay. So the purpose of OpenCL C++ is to provide a non-unified model that > > allows you to easily run C++ code on the CPU. > >

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

keryell added a comment. In https://reviews.llvm.org/D53705#1284268, @rjmccall wrote: > > Okay. So the purpose of OpenCL C++ is to provide a non-unified model that > allows you to easily run C++ code on the CPU. It is just the second-order purpose. A C++-based kernel language to program ac

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

rjmccall added a comment. In https://reviews.llvm.org/D53705#1284203, @keryell wrote: > I was really meaning "run on the CPU" and not "run on the GPU", it was not a > typo from me. :-) > If there are no visible language extensions besides C++ classes, it is > easier to run the kernel code on a

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

keryell added a comment. In https://reviews.llvm.org/D53705#1281743, @rjmccall wrote: > > New versions of C++ have semi-regularly added keywords like `static_assert` > and `thread_local` that are not in the reserved space for identifiers. When > C adopted these, it spelled them `_Static_as

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

Anastasia added a comment. FYI, I have created a bug to the OpenCL C++ spec: https://github.com/KhronosGroup/OpenCL-Docs/issues/13. Gladly, we now moved into discussing the issues publicly. So anyone can create bugs and also participate in discussions. I would like to feed all of the suggestio

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

rjmccall added a comment. In https://reviews.llvm.org/D53705#1281738, @keryell wrote: > In https://reviews.llvm.org/D53705#1278066, @rjmccall wrote: > > > I don't suppose there's any chance you can just tell Khronos to fix their > > stuff. It's a little funny to be more conservative about keywo

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

keryell added a comment. In https://reviews.llvm.org/D53705#1278066, @rjmccall wrote: > I don't suppose there's any chance you can just tell Khronos to fix their > stuff. It's a little funny to be more conservative about keywords in C++ > when the C++ committee is actually much more aggressive

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

keryell added a comment. We could submit to the standard an OpenCL C++ extension to accept the OpenCL C syntax... Repository: rC Clang https://reviews.llvm.org/D53705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

rjmccall added a comment. In https://reviews.llvm.org/D53705#1280264, @Anastasia wrote: > In https://reviews.llvm.org/D53705#1279086, @rjmccall wrote: > > > In https://reviews.llvm.org/D53705#1279068, @svenvh wrote: > > > > > Unlikely, since address spaces are provided in a different way in OpenC

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

Anastasia added a comment. In https://reviews.llvm.org/D53705#1279086, @rjmccall wrote: > In https://reviews.llvm.org/D53705#1279068, @svenvh wrote: > > > Unlikely, since address spaces are provided in a different way in OpenCL > > C++ vs OpenCL C. > > > > OpenCL C provides qualifiers such as `g

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

rjmccall added a comment. In https://reviews.llvm.org/D53705#1279068, @svenvh wrote: > Unlikely, since address spaces are provided in a different way in OpenCL C++ > vs OpenCL C. > > OpenCL C provides qualifiers such as `global` as part of the language. > OpenCL C++ provides template classes s

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

svenvh added a comment. Unlikely, since address spaces are provided in a different way in OpenCL C++ vs OpenCL C. OpenCL C provides qualifiers such as `global` as part of the language. OpenCL C++ provides template classes such as `cl::global` through a header file. Repository: rC Clang ht

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

rjmccall added a comment. I don't suppose there's any chance you can just tell Khronos to fix their stuff. It's a little funny to be more conservative about keywords in C++ when the C++ committee is actually much more aggressive about adding keywords in the non-reserved space than C is. Repo

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

svenvh created this revision. svenvh added reviewers: Anastasia, rjmccall. Herald added subscribers: cfe-commits, yaxunl. In OpenCL C++ mode, the "program scope variable must reside ..." diagnostic is firing early in some cases, potentially confusing the user. It is the first diagnostic reported