This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345973: [clangd] Add fallbackFlags initialization
extension. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53688?vs=171036&id=172351#toc
Repository:
rCT
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D53688#1275793, @sammccall wrote:
> It's hard to reason about UX outside of concrete tools - the only use I know
> of (atom-ide-cpp) never needs to ch
sammccall added a comment.
In https://reviews.llvm.org/D53688#1275586, @ilya-biryukov wrote:
> This feels like a configuration option that might be changed in the course of
> running clangd.
> Are there any strong reasons to make it work only upon initialization? My
> guess is that it keeps th
ilya-biryukov added a comment.
This feels like a configuration option that might be changed in the course of
running clangd.
Are there any strong reasons to make it work only upon initialization? My guess
is that it keeps the code simpler, but if we approached it purely from the UX
perspective,
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
This allows customizing the flags used when no compile database is
available. It addresses some uses of the old extraFlags extension.
