[PATCH] D53685: [WebAssembly] Bitselect and min/max builtins

2018-10-25 Thread Thomas Lively via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL345301: [WebAssembly] Bitselect and min/max builtins (authored by tlively, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53685 Files: cfe/tru

[PATCH] D53685: [WebAssembly] Bitselect and min/max builtins

2018-10-24 Thread Thomas Lively via Phabricator via cfe-commits
tlively added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:85 +BUILTIN(__builtin_wasm_bitselect, "V4iV4iV4iV4i", "nc") + aheejin wrote: > Do you think we need to provide this builtin also for other vector types? This builtin is inter

[PATCH] D53685: [WebAssembly] Bitselect and min/max builtins

2018-10-24 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:85 +BUILTIN(__builtin_wasm_bitselect, "V4iV4iV4iV4i", "nc") + Do you think we need to provide this builtin also for other vector types? Repository: rC Clang https://revi