[PATCH] D53641: [clangd] Remove didOpen extraFlags extension.

2018-11-02 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE345969: [clangd] Remove didOpen extraFlags extension. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D53641?vs=170858&id=172341#toc Repository: rCTE Clang

[PATCH] D53641: [clangd] Remove didOpen extraFlags extension.

2018-10-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. BTW I'm holding off submitting this until we decide the fate of https://reviews.llvm.org/D53688. If we're going to add that extension, I'd like to land the two patches together so the former user of this extension can rely on *one* of them being available. Repository

[PATCH] D53641: [clangd] Remove didOpen extraFlags extension.

2018-10-24 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Thanks for cleaning this up. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53641 ___ cfe-commits mailing li

[PATCH] D53641: [clangd] Remove didOpen extraFlags extension.

2018-10-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric. This was added in https://reviews.llvm.org/D34947 to support YCM, but YCM actually provides *all* args, and this was never actually use