[PATCH] D53638: [clangd] Downrank members from base class

This revision was automatically updated to reflect the committed changes. Closed by commit rL345140: [clangd] Downrank members from base class (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53638 Files: clang-tools

[PATCH] D53638: [clangd] Downrank members from base class

sammccall added inline comments. Comment at: clangd/Quality.cpp:380 + if (InBaseClass) +Score *= 0.7; + ioeric wrote: > sammccall wrote: > > This seems like a pretty light penalty to me, I'd consider 0.5... > 0.5 sounds reasonable. I think we should penalize

[PATCH] D53638: [clangd] Downrank members from base class

ioeric added inline comments. Comment at: clangd/Quality.cpp:380 + if (InBaseClass) +Score *= 0.7; + sammccall wrote: > This seems like a pretty light penalty to me, I'd consider 0.5... 0.5 sounds reasonable. I think we should penalize the non-instance membe

[PATCH] D53638: [clangd] Downrank members from base class

ioeric updated this revision to Diff 170870. ioeric marked an inline comment as done. ioeric added a comment. - adjust parameter Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53638 Files: clangd/Quality.cpp clangd/Quality.h unittests/clangd/QualityTests.cpp Index: unit

[PATCH] D53638: [clangd] Downrank members from base class

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/Quality.cpp:380 + if (InBaseClass) +Score *= 0.7; + This seems like a pretty light penalty to me, I'd consider 0.5... Rep

[PATCH] D53638: [clangd] Downrank members from base class

ioeric updated this revision to Diff 170862. ioeric marked an inline comment as done. ioeric added a comment. - restore accidentally removed test. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53638 Files: clangd/Quality.cpp clangd/Quality.h unittests/clangd/QualityTests

[PATCH] D53638: [clangd] Downrank members from base class

ioeric marked an inline comment as done. ioeric added inline comments. Comment at: unittests/clangd/QualityTests.cpp:187 Relevance.merge(CodeCompletionResult(&findDecl(AST, "S::S"), 42)); - EXPECT_EQ(Relevance.Scope, SymbolRelevanceSignals::GlobalScope); } i

[PATCH] D53638: [clangd] Downrank members from base class

ilya-biryukov added inline comments. Comment at: unittests/clangd/QualityTests.cpp:187 Relevance.merge(CodeCompletionResult(&findDecl(AST, "S::S"), 42)); - EXPECT_EQ(Relevance.Scope, SymbolRelevanceSignals::GlobalScope); } The test case was (accidentally?) r

[PATCH] D53638: [clangd] Downrank members from base class

ioeric created this revision. ioeric added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. ioeric added a dependency: D53635: [CodeComplete] Expose InBaseClass signal in code completion results.. Repository: rCTE Clang Tools Extr