[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

ilya-biryukov added inline comments. Comment at: lib/Sema/CodeCompleteConsumer.cpp:557 + if (!Tags.empty()) +OS << " (" << llvm::join(Tags, ",") << ")"; + if (CodeCompletionString *CCS = Results[I].CreateCodeCompletionString( ioeric wrote: > ily

[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345135: [CodeComplete] Expose InBaseClass signal in code completion results. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

ioeric added inline comments. Comment at: lib/Sema/CodeCompleteConsumer.cpp:557 + if (!Tags.empty()) +OS << " (" << llvm::join(Tags, ",") << ")"; + if (CodeCompletionString *CCS = Results[I].CreateCodeCompletionString( ilya-biryukov wrote: > NIT

[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

ioeric updated this revision to Diff 170855. ioeric added a comment. - Rebase Repository: rC Clang https://reviews.llvm.org/D53635 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/CodeCompleteConsumer.cpp lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/member-access.cpp

[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

ioeric updated this revision to Diff 170854. ioeric marked an inline comment as done. ioeric added a comment. - move tags into case. Repository: rC Clang https://reviews.llvm.org/D53635 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/CodeCompleteConsumer.cpp lib/Sema/SemaCode

[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

ilya-biryukov added a comment. And another NIT :-) Comment at: lib/Sema/CodeCompleteConsumer.cpp:548 OS << "COMPLETION: "; +std::vector Tags; switch (Results[I].Kind) { NIT: maybe move Tags into the corresponding case handler? Would require putti

[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a NIT Comment at: lib/Sema/CodeCompleteConsumer.cpp:557 + if (!Tags.empty()) +OS << " (" << llvm::join(Tags, ",") << ")"; + if (Code

[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

ioeric added a comment. In https://reviews.llvm.org/D53635#1273904, @ilya-biryukov wrote: > LG, but could we add a test for the new flag it by printing it in > `PrintingCodeCompleteConsumer::ProcessCodeCompleteResults()` and adding > corresponding tests to `clang/test/CodeCompletion`? > > Simil

[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

ioeric updated this revision to Diff 170838. ioeric added a comment. - Add tests for the new flag. Repository: rC Clang https://reviews.llvm.org/D53635 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/CodeCompleteConsumer.cpp lib/Sema/SemaCodeComplete.cpp test/CodeCompletion

[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

ilya-biryukov added a comment. LG, but could we add a test for the new flag it by printing it in `PrintingCodeCompleteConsumer::ProcessCodeCompleteResults()` and adding corresponding tests to `clang/test/CodeCompletion`? Repository: rC Clang https://reviews.llvm.org/D53635 __

[PATCH] D53635: [CodeComplete] Expose InBaseClass signal in code completion results.

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added a subscriber: cfe-commits. No new tests as the existing tests for result priority should give us coverage. Also as the new flag is trivial enough, I'm reluctant to plumb the flag to c-index-test output. Repository