This revision was automatically updated to reflect the committed changes.
Closed by commit rL345486: Support for groups of attributes in #pragma clang
attribute (authored by epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53621?
erik.pilkington marked an inline comment as done.
erik.pilkington added inline comments.
Comment at: clang/docs/LanguageExtensions.rst:2666
- #pragma clang attribute push(__attribute__((annotate("custom"))), apply_to =
function)
+ #pragma clang attribute push (__attribute__(
arphaman accepted this revision.
arphaman added a comment.
LGTM too when Aaron's comments are addressed
https://reviews.llvm.org/D53621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some small nits.
Comment at: clang/docs/LanguageExtensions.rst:2666
- #pragma clang attribute push(__attribute__((annotate("custom"))), apply
erik.pilkington updated this revision to Diff 171218.
erik.pilkington marked an inline comment as done.
erik.pilkington added a comment.
Add documentation and release notes, `{}`s. Thanks!
https://reviews.llvm.org/D53621
Files:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.rst
arphaman added a comment.
Thanks! It looks pretty good, just minor nit. could you also update the
language extension doc and release notes?
Comment at: clang/lib/Sema/SemaAttr.cpp:645
+
+ for (const PragmaAttributeEntry &Entry : PragmaAttributeStack.back().Entries)
+if (!
erik.pilkington created this revision.
erik.pilkington added reviewers: aaron.ballman, arphaman.
Herald added a subscriber: dexonsmith.
This patch allows pushing an empty `#pragma clang attribute push`, then adding
multiple attributes to it, then popping them all with `#pragma clang attribute
po
