[PATCH] D53609: [AST] Don't store data for GNU range case statement if not needed.

2018-10-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC345472: [AST] Don't store data for GNU range case statement if not needed (authored by brunoricci, committed by ). Repository: rC Clang https://reviews.llvm.org/D53609 Files: include/clang/AST/Stmt.

[PATCH] D53609: [AST] Don't store data for GNU range case statement if not needed.

2018-10-26 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno updated this revision to Diff 171336. riccibruno added a reviewer: rsmith. riccibruno added a comment. Add a flag in the output of -ast-dump to indicate that a `CaseStmt` is a GNU range case statement, following rsmith's comment in https://reviews.llvm.org/D53717 Repository: rC Clan

[PATCH] D53609: [AST] Don't store data for GNU range case statement if not needed.

2018-10-25 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D53609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D53609: [AST] Don't store data for GNU range case statement if not needed.

2018-10-25 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno updated this revision to Diff 171124. riccibruno added a comment. Reworked so that the order of the children is kept the same. Repository: rC Clang https://reviews.llvm.org/D53609 Files: include/clang/AST/Stmt.h lib/AST/ASTImporter.cpp lib/AST/Stmt.cpp lib/Sema/SemaStmt.cp

[PATCH] D53609: [AST] Don't store data for GNU range case statement if not needed.

2018-10-24 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: include/clang/AST/Stmt.h:956 + // with a range. Present if and only if caseStmtIsGNURange() is true. + enum { LHS, SUBSTMT, RHS, ELLIPSISLOC }; + enum { NumMandatoryStmtPtr = 2 }; ELLIPSISLOC is dead. Much like th

[PATCH] D53609: [AST] Don't store data for GNU range case statement if not needed.

2018-10-23 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno created this revision. riccibruno added a reviewer: rjmccall. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Don't store the data for case statements of the form `LHS ... RHS` if not needed. This cuts the size of `CaseStmt` by 1 pointer + 1 `SourceLocation`