This revision was automatically updated to reflect the committed changes.
Closed by commit rC345464: [AST] Only store the needed data in IfStmt (authored
by brunoricci, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53607
Files:
include/clang/AST/Stmt.h
lib/AST/ASTDumper.c
riccibruno updated this revision to Diff 171332.
riccibruno added a reviewer: rsmith.
riccibruno added a comment.
Add a flag to the output of -ast-dump indicating
which sub-statement `IfStmt` is storing. This removes
the ambiguity in the output of -ast-dump and addresses
rsmith's comment in https:
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D53607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
riccibruno updated this revision to Diff 171121.
riccibruno edited the summary of this revision.
riccibruno added a comment.
Reworked so that the order of the children is kept the same.
Repository:
rC Clang
https://reviews.llvm.org/D53607
Files:
include/clang/AST/Stmt.h
lib/AST/ASTImport
rjmccall added a comment.
Yeah, I agree that changing child order is problematic.
Repository:
rC Clang
https://reviews.llvm.org/D53607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
riccibruno added a comment.
To add on the issue of changing the order of the children. The more I think
about
it the less it seems to be a good idea. Every test passes but I strongly suspect
that a lot of code subtly rely on this.
Repository:
rC Clang
https://reviews.llvm.org/D53607
_
riccibruno created this revision.
riccibruno added a reviewer: rjmccall.
riccibruno added a project: clang.
Herald added subscribers: cfe-commits, javed.absar.
riccibruno added a dependency: D53605: [AST] Pack PredefinedExpr.
Only store the needed data in `IfStmt`. The various `Stmt *` are put in
