[PATCH] D53605: [AST] Refactor PredefinedExpr

2018-10-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL345460: [AST] Refactor PredefinedExpr (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53605?vs=171326&id=171406#toc

[PATCH] D53605: [AST] Refactor PredefinedExpr

2018-10-26 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: include/clang/AST/Stmt.h:279 +/// in PredefinedExpr::IdentType. +unsigned Type : 4; + rjmccall wrote: > Since you're changing t

[PATCH] D53605: [AST] Refactor PredefinedExpr

2018-10-26 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno updated this revision to Diff 171326. riccibruno marked 4 inline comments as done. riccibruno retitled this revision from "[AST] Pack PredefinedExpr" to "[AST] Refactor PredefinedExpr". riccibruno edited the summary of this revision. riccibruno added a comment. Address rjmcall's commen